Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#231 Refactor: 와인 정보/리뷰 보기 수정, WineWishlist 리패키징 #232

Merged
merged 9 commits into from
Dec 26, 2024
Merged

#231 Refactor: 와인 정보/리뷰 보기 수정, WineWishlist 리패키징 #232

merged 9 commits into from
Dec 26, 2024

Conversation

jeongyeon0208
Copy link
Member

@jeongyeon0208 jeongyeon0208 commented Dec 15, 2024 •
edited
Loading

  • 와인정보, 리뷰에 좋아요 반영 완료
  • 리뷰 정렬 기준 별점순 반영 완료
  • WineWishlist 리패키징 완료

@jeongyeon0208 jeongyeon0208 self-assigned this Dec 15, 2024
@jeongyeon0208 jeongyeon0208 changed the title #231 Refactor: 와인 정보, 리뷰 보기 수정 #231 Refactor: 와인 정보/리뷰 보기 수정, WineWishlist 리패키징 Dec 18, 2024
jeongyeon0208
jeongyeon0208 commented Dec 26, 2024
View reviewed changes
Copy link
Member Author

@jeongyeon0208 jeongyeon0208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • getTastingNoteNoseListByUsername(회원의 NoseList 정보 가져올 때)
  • showMemberNoseMapList(사용자가 작성한 TastingNoteNose 리스트 가져올 때)
  • findWineResponseByWineId(최근 생성된 tastingNoteList 불러올 때)

위 세 부분에서 Optional 없을 때 isEmpty() 결과 true(즉 null이 아님) 나오는 것 확인하여 Optional이 불필요해 삭제했습니다.

src/main/java/com/drinkeg/drinkeg/wine/repository/WineRepositoryImpl.java Show resolved Hide resolved
@jeongyeon0208 jeongyeon0208 merged commit b750ba4 into dev Dec 26, 2024
@jeongyeon0208 jeongyeon0208 deleted the refactor/231 branch December 26, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djlim2425 djlim2425 Awaiting requested review from djlim2425

@jeongyun1206 jeongyun1206 Awaiting requested review from jeongyun1206

Assignees

@jeongyeon0208 jeongyeon0208

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeongyeon0208 @jeongyun1206